JS: Derive type-tracking steps from flow summaries #18125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instantiates the library without using it yet.
asgerf
force-pushed
the
jss/summary-type-tracker
branch
from
1decdaf to
cab8a40
Compare
erik-krogh
approved these changes
Dec 3, 2024
Reminder: we have two PropertyName classes because the one in Contents.qll can't depend on DataFlow::Node.
erik-krogh
approved these changes
Dec 3, 2024
|
Evaluation still looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes type-tracking aware of flow summaries whose callees can be found with
getACallSimple(). This uses theSummaryTypeTrackerlibrary which I originally wrote for Ruby and which@yoffkindly ported to a parameterised module.Apart from just being nice to have, part of the motivation for this is to be able to deprecate things like
LegacyPreCallGraphStepand be able to present flow summaries as an alternative.Note that this contains the
Rename propagatesFlowExt -> propagatesFlowcommit that's also present in #18132.Evaluation looks neutral