KE2: Extract null literal
#18127
KE2: Extract null literal
#18127
Conversation
| val type = useType(t) | ||
| // Match Java by using a special <nulltype> for nulls, rather than Kotlin's view of this which is | ||
| // kotlin.Nothing?, the type that can only contain null. | ||
| val nullTypeName = "<nulltype>" |
There was a problem hiding this comment.
This isn't entirely consistent with Java, e.g.
public class Foo {
void foo() {
java.lang.Void v = true ? null : null;
}
}
gives
| Foo.java:3:28:3:45 | ...?...:... | file://:0:0:0:0 | <nulltype> |
| Foo.java:3:35:3:38 | null | file://:0:0:0:0 | <nulltype> |
| Foo.java:3:42:3:45 | null | file://:0:0:0:0 | <nulltype> |
(I'm not sure we have a Java test for that; might be worth adding one)
I think what we want is to check for Nothing? in useType, and return nullType for the Java type there.
There was a problem hiding this comment.
To check: I was recently requested to patch KE1 per #17890 to get the type of null consistent with Java
There was a problem hiding this comment.
Hmm, if Kotlin sees a function defined in Java as public java.lang.Void foo(), then does that look like a Nothing? return type in Kotlin?
There was a problem hiding this comment.
@igfoo, are you saying that KE2 is not consistent with KE1, or KE2/KE1 not consistent with the java extractor?
There was a problem hiding this comment.
KE2/KE1 not consistent with the java extractor
There was a problem hiding this comment.
If it's independent of KE2, then I think we should handle that inconsistency in a separate PR.
|
I rebased this PR to fix a merge conflict. |
No description provided.