Skip to content

Go: remove language tests from workflows #19781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redsun82
Copy link
Contributor

Now that they are run internally using QLucie.

Now that they are run internally using QLucie.
@github-actions github-actions bot added the Go label Jun 16, 2025
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just a question about this: why does go-tests.yml survive with a pull_request trigger, but go-tests-other-os.yml does not?

@redsun82
Copy link
Contributor Author

redsun82 commented Jun 19, 2025

Mostly just a question about this: why does go-tests.yml survive with a pull_request trigger, but go-tests-other-os.yml does not?

Linux was using the testing action with run-code-checks: true, so it was not just running language tests. The other-os and rtjo workflows weren't passing that option, which means they were only running language tests, which made those workflows entirely redundant with the internal tests.

To make this clearer we can probably remove the run-code-checks parameter, now that it is always true.

In any case, I think it's good to wait a bit with this to let the dust settle on the internal tests, like you mentioned on the internal PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants