-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Just: introduce common "verbs" #19978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
redsun82
wants to merge
23
commits into
main
Choose a base branch
from
redsun82/just2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces verbs (
build
,test
,format
,lint
,generate
) that individual parts of the project can implement, and some common functionality that can be used to that effect.The core of the functionality is given by forwarding. The idea is that:
just
behaviour (possibly using fallback).just test ql/rust/ql/test/{a,b}
, then a forwarder script finds a common justfile to all the positional arguments passed there, and then retries callingjust test
from there. Iftest
is implemented beneath that (in that case, it is inrust/ql/test
), it uses that recipe. Otherwise it detects falling back to the forwarder again and exits with an error.Another point is how launching QL tests can be tweaked:
codeql
standalone), and no additional database or consistency checks are made--codeql=built
can be passed to skip the build step (if no changes were made to the CLI/extractors). This is consistent with the same pytest option--all-checks
or the+
abbreviation. These additional checks are configured in justfiles per language.