feat: add getASupertype() predicate in ValueOrRefType. #20008
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the getASupertype() predicate in ValueOrRefType.
Create 2025-06-10-getasupertype.md
|
DCA looks good. |
| @@ -138,6 +138,9 @@ class ValueOrRefType extends Type, Attributable, @value_or_ref_type { | |||
| /** Gets an immediate subtype of this type, if any. */ | |||
| ValueOrRefType getASubType() { result.getABaseType() = this } | |||
|
|
|||
| /** Gets an immediate supertype of this type, if any. */ | |||
| ValueOrRefType getASupertype() { this.getABaseType() = result } | |||
There was a problem hiding this comment.
It looks like the capitalisation between Java and C# is a bit different - so for C# we probably need to name this predicate getASuperType to streamline it with the other predicate names.
| --- | ||
| category: feature | ||
| --- | ||
| * Added a new predicate, `getASupertype()`, to get a direct supertype of this type. |
There was a problem hiding this comment.
Need to adjust the name - see comment above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
getASupertype()predicate inValueOrRefTypelike in Java: https://codeql.github.com/codeql-standard-libraries/java/semmle/code/java/Type.qll/predicate.Type$RefType$getASupertype.0.htmlIt's my first PR for CodeQL let me know if I did something wrong :)