Rust: Include getAttributeMacroExpansion in isInMacroExpansion
#20273
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes false positives in Rust queries by ensuring that attribute macro expansions are properly identified as macro-expanded code. The change updates the isInMacroExpansion predicate to include attribute macros, which will prevent queries like rust/unused-variable and rust/unused-value from reporting issues within attribute macro expansions.
- Added attribute macro expansion detection to the
isInMacroExpansionpredicate - Added change notes documenting the improvement for minorAnalysis category
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/elements/internal/MacroCallImpl.qll | Enhanced macro expansion detection to include attribute macros |
| rust/ql/lib/change-notes/2025-08-25-in-macro-expansion.md | Documents the fix for attribute macro handling in analysis |
aibaars
approved these changes
Aug 25, 2025
geoffw0
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating this false positive report, I realized that the underlying cause was that attribute macros were not taken into account when filtering away results inside expansions.
DCA confirms that the FPs have been eliminated.