-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Rust: Rework type inference for method calls #20282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rust: Rework type inference for method calls #20282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
93a55b9
to
e4cfb86
Compare
e4cfb86
to
4a8c37c
Compare
) | ||
or | ||
// todo: add special case for operations with implicit borrows |
Check warning
Code scanning / CodeQL
Dead code Warning
class State = string; | ||
|
||
// private newtype TAccess = | ||
// TMethodCallAccess(MethodCallDerefChainRef mcd) or |
Check warning
Code scanning / CodeQL
Dead code Warning
// // t0 = getTypeQualifier(this, path0) and | ||
// // apos.getArgumentPosition(false).isSelf() and | ||
// // exists(state) | ||
// // else ( |
Check warning
Code scanning / CodeQL
Dead code Warning
// ) | ||
// } | ||
// bindingset[state] | ||
// pragma[nomagic] |
Check warning
Code scanning / CodeQL
Dead code Warning
// .getParameterType(TArgumentDeclarationPosition(apos.getArgumentPosition()), | ||
// TypePath::nil()) | ||
// | | ||
// if selfParamType = TRefType() |
Check warning
Code scanning / CodeQL
Dead code Warning
|
||
pragma[nomagic] | ||
private Type getACandidateReceiverTypeAtNoMatch(TypePath path, string derefChain) { | ||
this.receiverImplicitlyBorrowed() and |
Check warning
Code scanning / CodeQL
Dead code Warning
private Type getACandidateReceiverTypeAtRef(TypePath path, string derefChain) { | ||
// exists(TypePath path0, Type t0, string derefChain | | ||
// t0 = this.getACandidateReceiverTypeAt(path0, derefChain) | ||
// | |
Check warning
Code scanning / CodeQL
Dead code Warning
|
||
pragma[nomagic] | ||
private Type testgetACandidateReceiverTypeAtRefNoMatch2( | ||
TypePath path, string derefChain, Type rootType, string name, int arity |
Check warning
Code scanning / CodeQL
Dead code Warning
|
||
pragma[nomagic] | ||
private Type testgetACandidateReceiverTypeRefsAt(TypePath path, string derefChain) { | ||
result = this.getACandidateReceiverTypeRefsAt(path, derefChain) and |
Check warning
Code scanning / CodeQL
Singleton set literal Warning
@@ -1087,10 +1094,11 @@ | |||
* For example, if this access is the method call `M(42)`, then the inferred | |||
* type at argument position `0` is `int`. | |||
*/ | |||
Type getInferredType(AccessPosition apos, TypePath path); | |||
bindingset[state] |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
No description provided.