Skip to content

chore: primer react 37 #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SiriusCrain
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the dependency Dependency updates label Jun 1, 2025
@SiriusCrain
Copy link
Contributor Author

@setchy here is PR

@SiriusCrain SiriusCrain changed the title Chore/primer react 37 chore: primer react 37 Jun 1, 2025
@setchy
Copy link
Member

setchy commented Jun 1, 2025

@SiriusCrain - does the test suite run for you?

@SiriusCrain
Copy link
Contributor Author

@SiriusCrain - does the test suite run for you?

I am AFK, will check when can

@setchy
Copy link
Member

setchy commented Jun 1, 2025

I've also got a handful of other tailwind padding/margin changes locally to contribute later...

@SiriusCrain
Copy link
Contributor Author

SiriusCrain commented Jun 1, 2025

I've also got a handful of other tailwind padding/margin changes locally to contribute later...

I think you can add them or here or after merge, how will be ok for you

@SiriusCrain
Copy link
Contributor Author

I've also got a handful of other tailwind padding/margin changes locally to contribute later...

Problem with tests because jest cannot properly handle ESM syntax on which primer rely a lot, so I think it will be easier to migrate from jest first

@afonsojramos
Copy link
Member

Problem with tests because jest cannot properly handle ESM syntax on which primer rely a lot, so I think it will be easier to migrate from jest first

We've tried in the past and it was not super easy as we had a lot of the mocking was not working. But I can't completely recall.

@SiriusCrain
Copy link
Contributor Author

Problem with tests because jest cannot properly handle ESM syntax on which primer rely a lot, so I think it will be easier to migrate from jest first

We've tried in the past and it was not super easy as we had a lot of the mocking was not working. But I can't completely recall.

I get it, I am afraid that we cannot upgrade right now because of jest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants