-
Notifications
You must be signed in to change notification settings - Fork 274
chore: primer react 37 #2040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: primer react 37 #2040
Conversation
@setchy here is PR |
@SiriusCrain - does the test suite run for you? |
I am AFK, will check when can |
I've also got a handful of other tailwind padding/margin changes locally to contribute later... |
I think you can add them or here or after merge, how will be ok for you |
Problem with tests because jest cannot properly handle ESM syntax on which primer rely a lot, so I think it will be easier to migrate from jest first |
We've tried in the past and it was not super easy as we had a lot of the mocking was not working. But I can't completely recall. |
I get it, I am afraid that we cannot upgrade right now because of jest |
No description provided.