Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gitlab-sidekiq.service for GitLab v6.2.0 and above #170

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davispuh
Copy link

@davispuh davispuh commented Dec 5, 2013

since GitLab v6.2 it added script/background_jobs for Sidekiq launching so we'll use it.

@axilleas
Copy link
Contributor

While I like the idea of staying close to upstream, by making this change it would be more difficult to customize the paths if you'd like to follow the FHS and not use /home/git/. On the other hand I haven't given this much thought, any insights about this change?

@davispuh
Copy link
Author

I don't see why using other path would be problem? Before, with current implementation you've to change it in 3 places (if you've gitlab elsewhere), now with this it will be 4 places to change, but that doesn't matter as it's in same file so simply "Find & Replace". Or if you mean you want log files in /var/log rather than with GitLab that would be feature request for GitLab itself to allow customize them.

@davispuh
Copy link
Author

Changed script to bin dir because of GitLab changes with commit gitlabhq/gitlabhq@2341cef

I've been using this Systemd service for more than half a year and it works good ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants