gh-440: remove scipy as a test dependency #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saransh-cpp
commented
Nov 28, 2024
| def test_cumulative_trapezoid() -> None: | ||
| import scipy.integrate as spi | ||
|
|
||
| # 1D f and x |
There was a problem hiding this comment.
scipy just compares the result with the actual values - https://github.com/scipy/scipy/blob/1d57f315d9454446d333d37d19f2a44f4baf35c9/scipy/integrate/tests/test_quadrature.py#L183
|
|
||
| a = rng.standard_normal((100, 20)) | ||
| b = rng.standard_normal((100,)) | ||
| a = np.arange(25.0).reshape(-1, 5) |
There was a problem hiding this comment.
Saransh-cpp
force-pushed
the
saransh/no-scipy
branch
from
941c28b
to
b883f48
Compare
paddyroddy
approved these changes
Nov 28, 2024
Saransh-cpp
added
testing
ntessore
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove scipy as a test dependency and replace the tests with scipy's internal tests.
Closes: #440