Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb debug symbols when using lexical scope #1634

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Commits on Oct 18, 2024

  1. Plumb debug symbols when using lexical scope

    This change introduces a new `emit.debugSymbols` option that can be used
    to enable debug symbols when using lexical scope.
    wycats committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    90a1331 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Fix lint error

    wycats committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    eabb1ad View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Configuration menu
    Copy the full SHA
    48efb3d View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Allow meta to be undefined

    wycats committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b665241 View commit details
    Browse the repository at this point in the history
  2. Don't try to fix dynamic modifiers yet

    This case is not fixed by the current PR:
    
    ```
    <p {{some.modifier}}>
    ```
    
    It probably *should* result in `some.modifier` appearing as the `name`
    in the debug modifier tree, but the codepaths improved in the current PR
    don't fix that case. For this PR, we'll use the debug name provided by
    the modifier manager, which is at least not a regression.
    
    A future PR should systematically fix all of the cases that end up in
    the debug tree so that they *always* show "what the user typed",
    regardless of how it got converted into running code.
    wycats committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ddfb5f0 View commit details
    Browse the repository at this point in the history