Continue on with error-recovery infra refresh #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wycats
force-pushed
the
feature/error-recovery-redux-pt3
branch
from
4127f11
to
22e4216
Compare
wycats
force-pushed
the
feature/error-recovery-redux-pt3
branch
from
94e4b50
to
82e3457
Compare
wycats
force-pushed
the
feature/error-recovery-redux-pt3
branch
from
b79845d
to
a9717f3
Compare
wycats
force-pushed
the
feature/error-recovery-redux-pt3
branch
from
0fde5c8
to
f0a6f79
Compare
Move curried types to constants Improvements to the local debug output Further clean up metadata and fragment infra Improve symbols - Test `@names` in the debugger - Consolidate symbol names in multiple places - Rename "eval" names (a holdover from the partial days) to "debug" names. Future work could include further consolidating symbol names to rationalize lexical scope so that lexical names work in the debugger. Trace log cleanup This commit is mostly focused on changing the internals so that we can create complete trace logs without having to pass in the entire VM. Mostly finished implementing improved logging. More trace log improvements Fix lints
wycats
force-pushed
the
feature/error-recovery-redux-pt3
branch
from
f0a6f79
to
35817f7
Compare
|
There are still a number of places that could benefit from further improvements to their trace log representation, but this PR creates a strong foundation to build on and is, itself a significant improvement to the status quo. I ran the benchmarks locally and this PR didn't affect performance. This is to be expected since virtually all of the changes happened inside of |
|
perf test shows no difference 🎉 |
|
|
||
| function describeBlock( | ||
| block: AppendingBlock, | ||
| type: 'block:simple' | 'block:remote' | 'block:resettable' |
There was a problem hiding this comment.
simple blocks were renamed to appending blocks, yeah?
what determines simple vs remote vs resettable?
There was a problem hiding this comment.
- Appending: A block that will never be cleared. However, since it's possible to append a block to an Appending Block, the boundaries of an Appending Block can change. See
FirstNode/LastNodefor details on how this works. - Resettable: A block that can be reset (i.e. cleared). When a block is reset, its contents are cleared and it produces a new cursor to render a block into. This is used for constructs like
{{#if}}/{{else}}, which clear and rerender the block whenever the boolean value changes. - Remote: A block that represents a remote element. When the block is destroyed, the nodes rendered into the remote element are removed.
NullVoxPopuli
approved these changes
Nov 19, 2024
Yep, we do that |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on bringing in the improvements to local logging and debug infrastructure.
The code is a little bit elaborate, but it does a good job of making the debug trace logs for VM operations clear and comprehensible.
Here are some examples of improved output:
Notable:
%d,%o, etc.) are used for inline values with a built-in inline representation...x itemsfollowed by a representation of push and pop operations.In addition, it's possible to enable "subtle" mode, which shows all values rather than just changes.
Unchanged values are generally greyed out, so turning on subtle mode can be useful to get the full VM state for a change in normal trace logging mode, while still retaining the ability to identify changes.
Internally, there are two parts of this change:
jointo join a list of fragments with a separator). When combined, the new fragment has natural subtle behavior (e.g. a list made entirely of subtle valuesjoined with,is subtle).