Fix 213 Number: Integer and fraction digits format

[rxaviers]

Implements #213

[jzaefferer]

What UMD version is this based on? Neither current returnExports nor commonjsStrict use this check.

[jzaefferer]

Related discussion: qunitjs/qunit#540

[rxaviers]

It's based on https://github.com/jquery/jquery/blob/6de1d973a436282af7dfe3072924016c3cdc1984/src/intro.js, but skipping their window concerns. But, to be honest I didn't investigate why Core is following this approach instead of any of the UMDs you pointed out above.

On qunitjs/qunit#540, where can I find more info regarding "From previous chats with @jdalton, I believe there are a few more variations necessary to thoroughly export for all CommonJS environments, none of which require a nodeType check AFAIR"?

[jdalton]

The gist is

  if (checkForAMDFirst) {
    // amd define stuff
  }
  else if (freeExports && freeModule) {
    if (moduleExports) {
      // the reason you bolt `myFunc` onto `myFunc` is for
      // consistent use in environments without `module.exports`
      (freeModule.exports = myFunc).myFunc = ,myFunc;
    }
    else {
      freeExports.myFunc = myFunc;
    }
  }
  else {
    // in a browser
    root.myFunc = myFunc;
  }

The detection and assignment of checkForAMDFirst, freeExports, freeModule, moduleExports will vary.

[rxaviers]

Thanks @jdalton.

@jzaefferer, which UMD wrapper do you think we should use?

[jzaefferer]

We need something that we can test. There's some progress in that regard in here, though its still far from done: https://github.com/jquery/qunit/pull/540/files

I think for now our best bet is to stick with an appropriate UMD wrapper and let them figure out the compatibility issues.

[rxaviers]

I agree. So, I'm picking the returnExports flavor, and I've opened issue #221 to keep track of this change.

[jzaefferer]

Took me a while to figure out that I have to both npm install and bower install, eventually found it at the end of the readme. Maybe integrate grunt-bowercopy (using that in UI now)?

[rxaviers]

Took me a while to figure out that I have to both npm install and bower install, eventually found it at the end of the readme. Maybe integrate grunt-bowercopy (using that in UI now)?

@jzaefferer, I agree that triggering bower install from the Gruntfile saves the one time execution of such command. But, in the other hand, it keeps executing it (most of the times unnecessarily) on every build during development. If the case, can we make it a separate issue please?

[scottgonzalez]

The bowercopy command wouldn't be part of the build. It'd be a standalone command that you would run manually.

[rxaviers]

What's the gain then by replacing bower install for grunt <something>?

[jzaefferer]

On UI we use that to update the files in external, which are committed to the repo, so there's no need to do that for every clone of the repository. With bowercopy you can specify exactly which files you want, while bower itself usually copies a bunch of unnecessary files.

I don't know how useful that will be here though, it was a suggestion, not a requirement.

[rxaviers]

Ok. Thanks.