Update tests to actually treat 'flask' as optional #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flask
, for installing flask via theflask
extra-flask
in addition to-minimum_flask
flask/
test dir ifflask
can't be imported (also, rename the matching tests totests/flask/
)conftest.py
won't fail during test collectionThere's a long-standing inconsistency in that the tests have always required
flask
even though the library declares it to be an optional dependency.We may soon have an actual usage of this library (an AP CLI client) which doesn't need
flask
, so resolving this one way or the other will help ensure that installs don't have broken imports ifflask
is missing.