Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv in CI #231

Merged
merged 26 commits into from
Jul 18, 2024
Merged

Use uv in CI #231

merged 26 commits into from
Jul 18, 2024

Conversation

janbridley
Copy link
Collaborator

@janbridley janbridley commented Jul 8, 2024

Description

Testing for coxeter is very extensive, so the CI is slow. Updating the CI framework as well as the number of pytest threads should aid in this. I also added a (manually triggered) action to update pipfiles, and updated the current pipfiles to work with pip sync.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

.github/workflows/CI.yaml Outdated Show resolved Hide resolved
@janbridley janbridley marked this pull request as ready for review July 9, 2024 20:18
@janbridley janbridley requested review from a team, DomFijan and joaander and removed request for a team July 9, 2024 20:18
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have suggestions to improve this.

.github/workflows/CI.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
@janbridley janbridley enabled auto-merge (squash) July 11, 2024 13:40
@janbridley janbridley requested a review from joaander July 11, 2024 13:40
@janbridley janbridley disabled auto-merge July 11, 2024 14:21
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right now. The "Run workflow" button does not appear in https://github.com/glotzerlab/coxeter/actions/workflows/update_pipfiles.yaml so I'm not sure how to test this.

@janbridley janbridley merged commit 92bce83 into master Jul 18, 2024
9 checks passed
@janbridley janbridley deleted the ci/uv branch July 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants