Remove CircleCI from CI workflows #951
Conversation
for more information, see https://pre-commit.ci
|
Bumping the ci image from 2021.11 to 2022.05 seems to cause issues when trying to lint the C++ code. Will investigate further on this later. |
|
2019.7 seems to be our oldest supported version of tbb. |
.circleci/config.yml
Outdated
| # requires: | ||
| # - linux-python-38 | ||
| steps: | ||
| - run: echo "Nothing to do." |
There was a problem hiding this comment.
Just delete this file if it doesn't do anything.
There was a problem hiding this comment.
For some reason, circleci still tries to run even if I remove the config file and it shows up on github as a failed test. The dummy makes sure we can still get the coveted green check mark.
There was a problem hiding this comment.
Ah. That just takes some fixing on the GitHub / CircleCI website side of things. Go ahead and delete it, and let me know if you want help fixing that.
| @@ -1,5 +1,5 @@ | |||
| ase==3.16.0 | |||
| cmake==3.12.0 | |||
| cmake==3.13.0 | |||
There was a problem hiding this comment.
This was needed because of a change made in #950 (calling target_link_options). I don't remember why it didn't get caught in that PR, but I'm fixing it here.
| - ninja | ||
| - pip | ||
| - pip: | ||
| - -r requirements-test-compatible.txt |
There was a problem hiding this comment.
I'm surprised this works. conda-forge provides packages with a specific ABI that is not the same as PyPI's manylinux. Prefer the conda-forge provided packages and only fall back on pip installations when absolutely necessary. In such cases, consider contributing the package to the conda-forge ecosystem.
There was a problem hiding this comment.
run_tests.yml has to install the test dependencies plus tbb, but build_wheels.yml has to install the test dependencies without tbb. I could not think of any other way to have two separate sets of requirements files without writing the same pinned dependencies in two different places.
Description
This PR will remove CircleCI from all CI workflows, converting the windows tests to use github actions. I would also like this PR to reformat the current github actions CI to be more modular, and either fix or remove code coverage.
Motivation and Context
CircleCI workflows have been blocked because there are no credits on our plan. Github Actions is a better CI deal anyway, so its time to convert freud's CI workflows.
Coverage has been broken since our move to scikit-build.
Resolves: #947 #699
There is also an open pull request #749 which attempts to make the current CI format work with windows. I think this PR should make more sweeping CI changes than that PR would provide, so once this PR gets merged, that branch can be removed.
How Has This Been Tested?
We will push commits and make sure the CI acts as we want it to. To test CI related to releases, we will need to do some more investigation of the build artifacts. I am honestly not sure how to test that the release process works without making a release.
Types of changes
Checklist: