-
Notifications
You must be signed in to change notification settings - Fork 0
Pin CI packages to specific hashes #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+33
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pypa/gh-action-pypi-publish#378 should fix this when merged. |
joaander
reviewed
Aug 19, 2025
janbridley
added a commit
that referenced
this pull request
Aug 25, 2025
<!-- Provide a general summary of your changes in the Title above --> ## Description Previously, `parsnip` expected a path to a file (provided as either a str or a pathlib.Path), which was opened into a file buffer in the __init__ method. This is not optional, and a direct file buffer can now be provided. We also support raw text blocks (str containing newlines), which are preprocessed appropriately. **We make the assumption that all strings that do not point to a file, do not contain a portion of a valid path, and do not contain the ".cif" suffix should be treated as CIF data blocks.** ## Motivation and Context Resolves #49 Blocked by #51 ## Types of Changes <!-- Please select all items that apply, either now or after creating the pull request: --> - [ ] Documentation update - [ ] Bug fix - [x] New feature - [ ] Breaking change<sup>1</sup> <sup>1</sup>The change breaks (or has the potential to break) existing functionality and should be merged into the `breaking` branch ## Checklist: <!-- Please select all items that apply either now or after creating the pull request. --> - [x] I am familiar with the [Development Guidelines](https://github.com/glotzerlab/parsnip/blob/main/doc/source/development.rst) - [x] The changes introduced by this pull request are covered by existing or newly introduced tests. - [x] I have updated the [changelog](https://github.com/glotzerlab/parsnip/blob/main/ChangeLog.rst) and added my name to the [credits](https://github.com/glotzerlab/parsnip/blob/main/doc/source/credits.rst).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI has been updated to pin specific hashes of CI scripts, as per the new group standard.
Motivation and Context
Types of Changes
1The change breaks (or has the potential to break) existing functionality and should be merged into the
breaking
branchChecklist: