Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for charset attribute in search #263

Closed
wants to merge 1 commit into from

Conversation

Paxa
Copy link

@Paxa Paxa commented Nov 28, 2018

This allows to use non-ascii characters in search, e.g. Café

With this fix can be used as:

gmail.inbox.emails(gm: "Café".force_encoding('ascii-8bit'), charset: "UTF-8")

Solution inspired by dcparker/ruby-gmail#81

Would it be nice to apply UTF-8 as charset automatically?

@Paxa Paxa changed the title Add support for charset attribute Add support for charset attribute in search Nov 28, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.056% when pulling f53f95b on Paxa:master into c5e9389 on gmailgem:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.056% when pulling f53f95b on Paxa:master into c5e9389 on gmailgem:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.056% when pulling f53f95b on Paxa:master into c5e9389 on gmailgem:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.056% when pulling f53f95b on Paxa:master into c5e9389 on gmailgem:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.056% when pulling f53f95b on Paxa:master into c5e9389 on gmailgem:master.

@johnnyshields
Copy link
Contributor

As of version 0.7.0 (Aug 19, 2018) this gem is officially deprecated and will no longer be maintained. Please instead use Google's official Gmail API Ruby Client, which uses the Gmail API rather than IMAP and has significantly better performance and reliability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants