fix(tm2): deduct gas fee after runTx

[onlyhyde]

resolve #1070 #1067

This PR changes when and how gas fees are collected during transaction processing.
BREAKING CHANGE: need to modify the gas-fee value in your testcode to avoid the insufficient fund failure

As-Is

When : Collect the gas fee before the AnteHandler validates the signature of the transaction.
How: Sends the quantity of gas-fee that is set in the transaction from the originCaller's account to the `FeeCollectorAddress.

To-Be

When : Collect the gas fee immediately after the runTx function execution is terminated in the DeliverTx function (the final gas quantity used to process the Transaction is known at the end of the runTx function).
How : Sends the amount of gas-fee set in the transaction multiplied by the gas used from the originCaller's account to the FeeCollectorAddress.

Implementation

• Since the AnteHandler already does the work for gas and auth (https://github.com/gnolang/gno/blob/master/tm2/pkg/sdk/baseapp.go#L40), the GasFeeCollector's New function is implemented in ante.go to maintain that orientation.
• The GasFeeCollector function is called by the BaseApp, so in app.go, we set the GasFeeCollector function to BaseApp.
• Through the bank module, the code that sends the gas fees to the FeeCollectorAddress reuses an existing function (DeductFees).

Concerns

• After measuring the actual gas used, the calculated value with gas-fee is collected, and if there are not enough assets in the account at this time, a policy for handling the result of the transaction seems necessary.
  • Example) If you set 'gas-fee : 10ugnot' in the transaction, and the gas used is 10,000, the account balance must be 100,000 ugnot to submit the gas fee. If there are insufficient funds, return InsufficientFundsError. If an error is returned, the fee will not be collected, but since the transaction processing was done using a vm in the runTx function, it looks like the default fee may be required.

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests

[codecov]

Codecov Report

Attention: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
tm2/pkg/sdk/baseapp.go	22.22%	6 Missing and 1 partial ⚠️
tm2/pkg/sdk/options.go	75.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[notJoon]

In the meeting, I received confirmation that the concerning issues cannot occur. LGTM

remove: review/triage-pending flag

[onlyhyde]

Update as new issues are discovered.

Issue:

After processing a trasaction, if there are not enough assets for the gas fee, it is treated as a failure, but the status change is applied.

Cause:

After executing the runMsgs function in the runTx function, msCache.MultiWrite() updates the state if there is no failure in the result.
The gas fee collection is processed afterward, returning a failure, but the state remains updated.

Fix:

• Change to collect the gas fee before updating the status.
• If an error occurs while collecting the gas fee, return an error.
• If you're processing a genesis block, add a condition to not collect the gas fee.