feat(boards2): add pagination #3216
Conversation
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
x1unix
force-pushed
the
feat/use-pager
branch
from
918cc79
to
0918c2e
Compare
| pg := pager.NewPager(&board.threads, p.PageSize) | ||
| page := pg.GetPage(p.PageNumber) |
There was a problem hiding this comment.
Is it not possible to use something like the following?
| pg := pager.NewPager(&board.threads, p.PageSize) | |
| page := pg.GetPage(p.PageNumber) | |
| page := pager.NewPager(&board.threads, boardsPageSize).MustGetPageByPath(path) |
Where path is the render path. This would allow to remove the Pagination struct.
There was a problem hiding this comment.
@jeronimoalbi the idea here is to have separation of concerns, so render.gno which acts as a controller will be responsible for getting pagination query string information.
| pg := pager.NewPager(&gBoardsByID, defaultPageSize) | ||
| pageNum, limit, err := pg.ParseQuery(r.requestUri) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| page := pg.GetPageWithSize(pageNum, limit) |
There was a problem hiding this comment.
@x1unix what do you think about just using MustGetPageByPath everywhere? Is there a constraint not to use it also here?
There was a problem hiding this comment.
@jeronimoalbi please check response above.
|
@x1unix let's not wrap the router, lets use it even if it doesn't support query string arguments. At this point is not a blocker as the listing will work, caveat is that only the first page for now. |
This PR adds pagination for boards and posts list using
p/demo/avl/pagerpackage.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the descriptionCC @jeronimoalbi