-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): show object updates using difflib, log blocks #3894
base: master
Are you sure you want to change the base?
fix(gnovm): show object updates using difflib, log blocks #3894
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
…-update-log-using-diff
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
// + "OwnerID": "a8ada09dee16d791fd406d629fe29bb0ed084a30:7", | ||
// "RefCount": "1" | ||
// }, | ||
// "Value": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line and the next ones look weird, nope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to provide some context so that there is some idea of what is actually being modified; imo it is intelligible given the indentation of the diff. Do you think it should be done differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work—approved! ^^
adds to #3893
changes logs from opslog so that when we're logging an update, we only log the updated lines
conditionally enables opslog based on whether the filetest needs it.