feat(examples): add p/moul/errs #3926

moul · 2025-03-12T16:29:51Z

Based on https://go.uber.org/multierr which is my favorite multi-error library in go.

Signed-off-by: moul <[email protected]>

Gno2D2 · 2025-03-12T16:31:03Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)
Then
🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission

thehowl · 2025-03-13T17:56:57Z

examples/gno.land/p/moul/errs/errs.gno

+
+// Errors returns the slice of underlying errors contained in this multiError.
+// Returns nil if the receiver is nil.
+func (m *multiError) Errors() []error {


Unwrap() []error?

We don't have the extra functions in errors, but I think we should in the future, post-reflection

thehowl · 2025-03-13T17:58:14Z

examples/gno.land/p/moul/errs/errs.gno

+// Combine merges multiple errors into a single error efficiently.
+// It handles several cases:
+//   - If all input errors are nil, returns nil
+//   - If there's exactly one non-nil error, returns that error directly
+//   - If there are multiple non-nil errors, returns a multiError containing them
+func Combine(errs ...error) error {


Could you not remove Append, and instead handle the case in this function where the err.(*multiErr) in the range?

feat(examples): add p/moul/errs

2451b02

Signed-off-by: moul <[email protected]>

moul self-assigned this Mar 12, 2025

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Mar 12, 2025

chore: fixup

65d9c81

thehowl reviewed Mar 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(examples): add p/moul/errs #3926

feat(examples): add p/moul/errs #3926

moul commented Mar 12, 2025 •

edited

Loading

Gno2D2 commented Mar 12, 2025 •

edited

Loading

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

thehowl Mar 13, 2025

thehowl Mar 13, 2025

feat(examples): add p/moul/errs #3926

Are you sure you want to change the base?

feat(examples): add p/moul/errs #3926

Conversation

moul commented Mar 12, 2025 • edited Loading

Gno2D2 commented Mar 12, 2025 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

thehowl Mar 13, 2025

Choose a reason for hiding this comment

thehowl Mar 13, 2025

Choose a reason for hiding this comment

moul commented Mar 12, 2025 •

edited

Loading

Gno2D2 commented Mar 12, 2025 •

edited

Loading