Skip to content

Improvements to existing NSDataLink code #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions Headers/AppKit/NSDataLink.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,25 +64,25 @@ APPKIT_EXPORT_CLASS
// Attributes
@private
// link info.
NSDataLinkNumber linkNumber;
NSDataLinkDisposition disposition;
NSDataLinkUpdateMode updateMode;
NSDataLinkNumber _linkNumber;
NSDataLinkDisposition _disposition;
NSDataLinkUpdateMode _updateMode;

// info about the source.
NSDate *lastUpdateTime;
NSString *sourceApplicationName;
NSString *sourceFilename;
NSSelection *sourceSelection;
id sourceManager;
NSDate *_lastUpdateTime;
NSString *_sourceApplicationName;
NSString *_sourceFilename;
NSSelection *_sourceSelection;
id _sourceManager;

// info about the destination
NSString *destinationApplicationName;
NSString *destinationFilename;
NSSelection *destinationSelection;
id destinationManager;
NSString *_destinationApplicationName;
NSString *_destinationFilename;
NSSelection *_destinationSelection;
id _destinationManager;

// types.
NSArray *types;
NSArray *_types;

// other flags
struct __linkFlags {
Expand Down
84 changes: 42 additions & 42 deletions Headers/AppKit/NSDataLinkManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ APPKIT_EXPORT_CLASS
@interface NSDataLinkManager : NSObject <NSCoding>
{
// Attributes
id delegate;
NSString *filename;
NSMutableArray *sourceLinks;
NSMutableArray *destinationLinks;
id _delegate;
NSString *_filename;
NSMutableArray *_sourceLinks;
NSMutableArray *_destinationLinks;

struct __dlmFlags {
unsigned areLinkOutlinesVisible:1;
Expand All @@ -62,22 +62,22 @@ APPKIT_EXPORT_CLASS
//
// Initializing and Freeing a Link Manager
//
- (id)initWithDelegate:(id)anObject;
- (id)initWithDelegate:(id)anObject
fromFile:(NSString *)path;
- (id) initWithDelegate: (id)anObject;
- (id) initWithDelegate: (id)anObject
fromFile: (NSString *)path;

//
// Adding and Removing Links
//
- (BOOL)addLink:(NSDataLink *)link
at:(NSSelection *)selection;
- (BOOL)addLinkAsMarker:(NSDataLink *)link
at:(NSSelection *)selection;
- (NSDataLink *)addLinkPreviouslyAt:(NSSelection *)oldSelection
fromPasteboard:(NSPasteboard *)pasteboard
at:(NSSelection *)selection;
- (BOOL)addLink: (NSDataLink *)link
at: (NSSelection *)selection;
- (BOOL)addLinkAsMarker: (NSDataLink *)link
at: (NSSelection *)selection;
- (NSDataLink *)addLinkPreviouslyAt: (NSSelection *)oldSelection
fromPasteboard: (NSPasteboard *)pasteboard
at: (NSSelection *)selection;
- (void)breakAllLinks;
- (void)writeLinksToPasteboard:(NSPasteboard *)pasteboard;
- (void)writeLinksToPasteboard: (NSPasteboard *)pasteboard;

//
// Informing the Link Manager of Document Status
Expand All @@ -86,8 +86,8 @@ APPKIT_EXPORT_CLASS
- (void)noteDocumentEdited;
- (void)noteDocumentReverted;
- (void)noteDocumentSaved;
- (void)noteDocumentSavedAs:(NSString *)path;
- (void)noteDocumentSavedTo:(NSString *)path;
- (void)noteDocumentSavedAs: (NSString *)path;
- (void)noteDocumentSavedTo: (NSString *)path;

//
// Getting and Setting Information about the Link Manager
Expand All @@ -97,16 +97,16 @@ APPKIT_EXPORT_CLASS
- (NSString *)filename;
- (BOOL)interactsWithUser;
- (BOOL)isEdited;
- (void)setDelegateVerifiesLinks:(BOOL)flag;
- (void)setInteractsWithUser:(BOOL)flag;
- (void)setDelegateVerifiesLinks: (BOOL)flag;
- (void)setInteractsWithUser: (BOOL)flag;

//
// Getting and Setting Information about the Manager's Links
//
- (BOOL)areLinkOutlinesVisible;
- (NSEnumerator *)destinationLinkEnumerator;
- (NSDataLink *)destinationLinkWithSelection:(NSSelection *)destSel;
- (void)setLinkOutlinesVisible:(BOOL)flag;
- (NSDataLink *)destinationLinkWithSelection: (NSSelection *)destSel;
- (void)setLinkOutlinesVisible: (BOOL)flag;
- (NSEnumerator *)sourceLinkEnumerator;
@end

Expand All @@ -116,29 +116,29 @@ APPKIT_EXPORT_CLASS
//
@interface NSObject (NSDataLinkManagerDelegate)
// data link management methods.
- (void)dataLinkManager:(NSDataLinkManager *)sender
didBreakLink:(NSDataLink *)link;
- (BOOL)dataLinkManager:(NSDataLinkManager *)sender
isUpdateNeededForLink:(NSDataLink *)link;
- (void)dataLinkManager:(NSDataLinkManager *)sender
startTrackingLink:(NSDataLink *)link;
- (void)dataLinkManager:(NSDataLinkManager *)sender
stopTrackingLink:(NSDataLink *)link;
- (void)dataLinkManagerCloseDocument:(NSDataLinkManager *)sender;
- (void)dataLinkManagerDidEditLinks:(NSDataLinkManager *)sender;
- (void)dataLinkManagerRedrawLinkOutlines:(NSDataLinkManager *)sender;
- (BOOL)dataLinkManagerTracksLinksIndividually:(NSDataLinkManager *)sender;
- (void)dataLinkManager: (NSDataLinkManager *)sender
didBreakLink: (NSDataLink *)link;
- (BOOL)dataLinkManager: (NSDataLinkManager *)sender
isUpdateNeededForLink: (NSDataLink *)link;
- (void)dataLinkManager: (NSDataLinkManager *)sender
startTrackingLink: (NSDataLink *)link;
- (void)dataLinkManager: (NSDataLinkManager *)sender
stopTrackingLink: (NSDataLink *)link;
- (void)dataLinkManagerCloseDocument: (NSDataLinkManager *)sender;
- (void)dataLinkManagerDidEditLinks: (NSDataLinkManager *)sender;
- (void)dataLinkManagerRedrawLinkOutlines: (NSDataLinkManager *)sender;
- (BOOL)dataLinkManagerTracksLinksIndividually: (NSDataLinkManager *)sender;

// selection management methods.
- (BOOL)copyToPasteboard:(NSPasteboard *)pasteboard
at:(NSSelection *)selection
cheapCopyAllowed:(BOOL)flag;
- (BOOL)importFile:(NSString *)filename
at:(NSSelection *)selection;
- (BOOL)pasteFromPasteboard:(NSPasteboard *)pasteboard
at:(NSSelection *)selection;
- (BOOL)showSelection:(NSSelection *)selection;
- (NSWindow *)windowForSelection:(NSSelection *)selection;
- (BOOL)copyToPasteboard: (NSPasteboard *)pasteboard
at: (NSSelection *)selection
cheapCopyAllowed: (BOOL)flag;
- (BOOL)importFile: (NSString *)filename
at: (NSSelection *)selection;
- (BOOL)pasteFromPasteboard: (NSPasteboard *)pasteboard
at: (NSSelection *)selection;
- (BOOL)showSelection: (NSSelection *)selection;
- (NSWindow *)windowForSelection: (NSSelection *)selection;
@end


Expand Down
Loading