refactor(signal): Refactor async feature (#83)

Signed-off-by: Flc゛ <[email protected]>
go-fries · Jan 30, 2024 · 7486cc3 · 7486cc3
1 parent 2ff07fd
commit 7486cc3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 12 deletions.
diff --git a/signal/README.md b/signal/README.md
@@ -11,6 +11,7 @@ import (
 
 	"github.com/go-kratos/kratos/v2"
 
+	"github.com/go-kratos-ecosystem/components/v2/feature"
 	"github.com/go-kratos-ecosystem/components/v2/signal"
 )
 
@@ -45,7 +46,7 @@ func (h *exampleHandler) Handle(sig os.Signal) {
 }
 
 type example2Handler struct{
-	signal.AsyncFeature // async feature
+	feature.AsyncFeature // async feature
 }
 
 func (h *example2Handler) Listen() []os.Signal {

diff --git a/signal/handler.go b/signal/handler.go
@@ -8,13 +8,3 @@ type Handler interface {
 	Listen() []os.Signal
 	Handle(os.Signal)
 }
-
-type asyncFeature interface {
-	Async() bool
-}
-
-type AsyncFeature struct{}
-
-func (*AsyncFeature) Async() bool {
-	return true
-}
diff --git a/signal/server.go b/signal/server.go
@@ -6,6 +6,8 @@ import (
 	"os/signal"
 
 	"github.com/go-kratos/kratos/v2/log"
+
+	"github.com/go-kratos-ecosystem/components/v2/feature"
 )
 
 var DefaultRecovery = func(err interface{}, sig os.Signal, handler Handler) {
@@ -80,7 +82,7 @@ func (s *Server) Start(ctx context.Context) error {
 			if hs, ok := handlers[sig]; ok {
 				for _, h := range hs {
 					// if Support asyncFeature
-					if async, ok := h.(asyncFeature); ok && async.Async() {
+					if async, ok := h.(feature.Asyncable); ok && async.Async() {
 						go s.handle(sig, h)
 					} else {
 						s.handle(sig, h)