Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(syslog): the syslog service cannot be started properly because it… #31

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

flc1125
Copy link
Contributor

@flc1125 flc1125 commented Nov 16, 2023

… is unstable

Copy link

what-the-diff bot commented Nov 16, 2023

PR Summary

  • Improved Functionality in syslog.go
    The New function in the syslog.go file has been enhanced by eliminating error handling for connection problems. Moreover, before attempting to log, we have updated the Log function to verify if a connection is present. These changes help to ensure smoother and more efficient operations.

  • Updated Testing Procedure in syslog_test.go
    Modifications have been made to the syslog_test.go file to skip the testing process when deployed on a Windows environment. This avoids unnecessary operations and optimizes tests to operate efficiently under varying conditions.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (13c3411) 71.21% compared to head (08bfd80) 74.79%.

Files Patch % Lines
log/syslog/syslog.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   71.21%   74.79%   +3.57%     
==========================================
  Files          22       22              
  Lines         608      607       -1     
==========================================
+ Hits          433      454      +21     
+ Misses        162      137      -25     
- Partials       13       16       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flc1125 flc1125 merged commit 225e60d into master Nov 16, 2023
5 of 6 checks passed
@flc1125 flc1125 deleted the feat-syslog branch November 16, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant