Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sms): Added SMS(with mitake provider) #67

Merged
merged 5 commits into from
Jan 10, 2024
Merged

feat(sms): Added SMS(with mitake provider) #67

merged 5 commits into from
Jan 10, 2024

Conversation

flc1125
Copy link
Contributor

@flc1125 flc1125 commented Jan 10, 2024

No description provided.

Signed-off-by: Flc゛ <[email protected]>
@flc1125 flc1125 changed the title feat(sms): Added SMS feat(sms): Added SMS(with mitake provider) Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (e896616) 79.56% compared to head (3bd0b88) 79.15%.

Files Patch % Lines
sms/mitake/provider.go 65.00% 14 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x      #67      +/-   ##
==========================================
- Coverage   79.56%   79.15%   -0.42%     
==========================================
  Files          21       24       +3     
  Lines         690      777      +87     
==========================================
+ Hits          549      615      +66     
- Misses        124      138      +14     
- Partials       17       24       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flc1125 flc1125 merged commit 6ee3703 into 2.x Jan 10, 2024
5 of 7 checks passed
@flc1125 flc1125 deleted the sms branch January 10, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant