Skip to content
This repository has been archived by the owner on Dec 2, 2017. It is now read-only.

update the customizing section #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update the customizing section #100

wants to merge 2 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 11, 2017

As title.

@lunny lunny added this to the 1.2 milestone Mar 11, 2017
@lunny
Copy link
Member Author

lunny commented Mar 11, 2017

@tboerger please review

@metalmatze
Copy link
Contributor

LGTM

@lunny lunny modified the milestones: 1.1, 1.2 Mar 11, 2017

## Customizing licenses/readme/locales/labels/gitignores

Put your customerize files into `custom/options/license`/`custom/options/readme/`/`custom/options/locale`/`custom/options/label/`/`custom/options/gitignore`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you introduced GITEA_CUSTOM above, maybe this document could be consistent and use ${GITEA_CUSTOM} instead of just custom ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe build an unordered list for the available customizations.

@@ -17,6 +17,22 @@ menu:

The main way to customize Gitea is by using the `custom` folder. This is the central place to override and configure features.

## Specify my customerize folder

Set the env `GITEA_CUSTOM`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify that not setting it defaults to a custom directory and where such directory is resolved when relative (like in the default case)

@@ -17,6 +17,22 @@ menu:

The main way to customize Gitea is by using the `custom` folder. This is the central place to override and configure features.

## Specify my customerize folder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it to Specify the custom folder


## Customizing static files

Put your static files on `custom/public/`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as what @strk said


## Customizing templates

Put your template files on `custom/templates/`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as what @strk said

## Specify the custom folder

The default custom folder is `GITEA_HOME/custom`, and you can set it by the env `GITEA_CUSTOM`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it GITEA_WORK_DIR instead of GITEA_HOME ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, confusing, gitea uses both GITEA_HOME and GITEA_WORK_DIR :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok now I see, it's only GITEA_WORK_DIR that is used by gitea. The GITEA_HOME variable is just internal variable for init scripts, so please update the patch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strk This should be documented somewhere. All the env vars get quite confusing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geek1011 see #111 - hopefully @blankoworld will take care of that (will you?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will. I'm checking all os.Getenv in Gitea code and extract them. Then I list them on a page to explain what they do in the code. I will put the changes in #111, so that we can talk about it.

Copy link
Member

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix GITEA_HOME reference, should really be GITEA_WORK_DIR

@strk
Copy link
Member

strk commented Apr 6, 2017

@lunny are you going to fix this ? See also #111


## Customizing templates

Put your template files on `custom/templates/`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in, not on.

@appleboy
Copy link
Member

7ee0103

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants