This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
fix submodule has port #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 33.01% 34.07% +1.06%
==========================================
Files 28 28
Lines 1784 1790 +6
==========================================
+ Hits 589 610 +21
+ Misses 1118 1100 -18
- Partials 77 80 +3
Continue to review full report at Codecov.
|
lafriks
approved these changes
Dec 9, 2018
sapk
approved these changes
Jan 22, 2019
sapk
reviewed
Jan 22, 2019
| }{ | ||
| {"git://github.com/user1/repo1", "/", "/", "http://github.com/user1/repo1"}, | ||
| {"https://localhost/user1/repo1.git", "/", "/", "https://localhost/user1/repo1"}, | ||
| {"[email protected]/user1/repo1.git", "/", "/", "[email protected]/user1/repo1"}, |
There was a problem hiding this comment.
Shouldn't we prefix it with http if it doesn't contain a scheme ? and drop the user ?
I am not blocking on this as it improve the existing func.
There was a problem hiding this comment.
Do you mean [email protected]/user1/repo1.git => http://github.com/user1/repo1.git ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix go-gitea/gitea#2775 and replace #108