Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation for docs #3030

Merged
merged 2 commits into from
Nov 30, 2017
Merged

French translation for docs #3030

merged 2 commits into from
Nov 30, 2017

Conversation

techknowlogick
Copy link
Member

original PR go-gitea/docs#147 and author @0xBAADF00D

@lafriks
Copy link
Member

lafriks commented Nov 29, 2017

I don't think we can keep it updated and it's better to not have translation than have outdated one but that's just my personal opinion.
At least while we don't have something like for web UI where we can keep them in sync

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2017
@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #3030 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
- Coverage      33%   32.98%   -0.03%     
==========================================
  Files         270      270              
  Lines       39549    39549              
==========================================
- Hits        13054    13044      -10     
- Misses      24644    24650       +6     
- Partials     1851     1855       +4
Impacted Files Coverage Δ
models/repo_indexer.go 45.54% <0%> (-3.47%) ⬇️
models/repo.go 37.82% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d517b56...dea8701. Read the comment docs.

@techknowlogick
Copy link
Member Author

@lafriks I agree we probably won't be able to keep them in synch (unless we can use crowdin for something like this), but at least this will give us a head start until we get to that point.

Going through these with my (limited) french, they don't seem too out of date (well except the docker one, but at least those instructions still work). I'd need a person who actually speaks french to confirm this. The original PR is from august 23rd, and there are only 15ish commits to the docs since that time.

I'm ok either way (merging it, or not merging it) I just figured I'd give the option.

@sapk
Copy link
Member

sapk commented Nov 29, 2017

We could add a comment on header that indicate the recommended/updated docs is english ?

@techknowlogick
Copy link
Member Author

@sapk that sounds like a good idea. I'm afraid my french ability doesn't allow me to write that sentence, would you be able to help?

@lunny
Copy link
Member

lunny commented Nov 30, 2017

So let's LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2017
Tous les binaires sont livrés avec le support de SQLite, MySQL et PostgreSQL, et sont construits avec les ressources incorporées. Gardez à l'esprit que cela peut être différent pour les versions antérieures. L'installation basée sur nos binaires est assez simple, il suffit de choisir le fichier correspondant à votre plateforme à partir de la [page de téléchargement](https://dl.gitea.io/gitea). Copiez l'URL et remplacer l'URL dans les commandes suivantes par la nouvelle:

```
wget -O gitea https://dl.gitea.io/gitea/1.0.1/gitea-1.0.1-linux-amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update link?

@sapk
Copy link
Member

sapk commented Nov 30, 2017

@techknowlogick this could be done later.
LGTM for backporting.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 30, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Nov 30, 2017
@lunny lunny merged commit 474dfcc into go-gitea:master Nov 30, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants