Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "View all branches/tags" entry to Branch Selector #32653

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Add "View all branches/tags" entry to Branch Selector #32653

merged 10 commits into from
Dec 2, 2024
+15 −0

Conversation

kerwin612
Copy link
Member

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2024
@wxiaoguang

This comment was marked as resolved.

Sign in to view
@kerwin612 kerwin612 closed this Nov 27, 2024
@kerwin612 kerwin612 deleted the patch-24 branch November 27, 2024 05:39
@kerwin612 kerwin612 restored the patch-24 branch November 27, 2024 05:41
@kerwin612 kerwin612 reopened this Nov 27, 2024
@kerwin612
Copy link
Member Author

  1. I do not think it is right because this selector is used by many other pages.
  2. please name the branch name properly, I can't figure which branch is for what.

I have revised it to: "The new entry is only available on the repository homepage" .
Regarding the branch name, I will pay attention to it later. Thanks for the suggestion.

wxiaoguang
wxiaoguang reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not look good to me but I won't block it if other reviewers like&approve it.

@kerwin612 kerwin612 requested review from lunny and a team November 27, 2024 11:25
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 27, 2024
@justusbunsi
Copy link
Member

@kerwin612 In what way does this change the current behavior. From the code changes and only the screenshot as PR description I have no idea what the diff does. Could you explain it, please.

@lunny
Copy link
Member

lunny commented Nov 27, 2024

Can you add some descriptions about why we need this sub-menu?

@yp05327
Copy link
Member

yp05327 commented Nov 27, 2024

Need more descriptions +1

@kerwin612
Copy link
Member Author

@kerwin612 In what way does this change the current behavior. From the code changes and only the screenshot as PR description I have no idea what the diff does. Could you explain it, please.

The theme of this PR is: "A new shortcut has been added to the branch selector on the repository's homepage, enabling quick navigation to the [All Branches/Tags] page

@kerwin612
Copy link
Member Author

Honestly, the reason for adding this entry is quite simple; it's just that I'm used to using this entry on GitHub, and I feel a bit uneasy without it on Gitea. So I added this entry to align it with GitHub. @yp05327 @lunny @justusbunsi
b1bc8742c17d75357931993c4a27b99

@yp05327
Copy link
Member

yp05327 commented Nov 28, 2024 •
edited
Loading

I understand now. Then it should be View all branches/tags not All branches/tags, or it is hard to understand what is it used for.

ps:
You can also access all branches from:
In Gitea:
image
In GitHub:
image

@justusbunsi
Copy link
Member

@kerwin612 Thanks for your explanation. As @yp05327 mentioned, there are already shortcuts to both views - with less clicks needed to reach them. For me it doesn't seem like a useful addition.

@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 28, 2024

It may be useful on sub pages without the branch link:
grafik

@justusbunsi
Copy link
Member

It may be useful on sub pages without the branch link:
grafik

Good point. Haven't thought about this.

@lunny lunny changed the title Add "All branches/tags" entry to Branch Selector Add "View all branches/tags" entry to Branch Selector Nov 28, 2024
@wxiaoguang
Copy link
Contributor

Do this first to clean up the legacy code: Refactor RepoBranchTagSelector #32681

@wxiaoguang
Copy link
Contributor

Is there any objection to merge? If no, please vote your approval.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 2, 2024
@lunny lunny added this to the 1.23.0 milestone Dec 2, 2024
@lunny lunny enabled auto-merge (squash) December 2, 2024 19:55
@lunny lunny merged commit 576e31a into go-gitea:main Dec 2, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@hiifong hiifong hiifong approved these changes

@lunny lunny lunny approved these changes

@yp05327 yp05327 Awaiting requested review from yp05327

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files modifies/translation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
8 participants
@kerwin612 @wxiaoguang @justusbunsi @lunny @yp05327 @KN4CK3R @hiifong @GiteaBot