Skip to content

Fixed minor typos in two files #HSFDPMUW #34944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MrMars98
Copy link

@MrMars98 MrMars98 commented Jul 3, 2025

Fixed minor typos in CODE_OF_CONDUCT.md and README.md

I use the hashtag for a project at my university

MrMars98 added 2 commits July 3, 2025 13:44
I use the hashtag for a project at my university

Signed-off-by: MrMars98 <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 3, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 3, 2025
@techknowlogick
Copy link
Member

Thanks for the PR, are you able to provide more context of the hashtag/your university course?

@TheFox0x7
Copy link
Contributor

I've looked into this out of curiosity. I have not found which university runs this course but it has been running since 2022.
They use the tag to id the contributions for the class. It's mainly been typo fixing.

Btw consider letting whoever runs the course know that the arbitrary tag with 0 context is a very weird choice. Especially for a title which is sometimes automated into release notes. PR body would be a better place IMO for it but I know it's most likely not up to you.

@bytedream
Copy link
Contributor

bytedream commented Jul 3, 2025

I can confirm. I'm at the same university and funnily enough also visited that course (my PRs). For every PR with that hashtag (max. 5) you'll get points which you need to reach the best possible grade.

They use the tag to id the contributions for the class. It's mainly been typo fixing.

The only requirement is to have a merged PR with the hashtag in the title. The lecture is mostly visited by first semester students (some of whom have just learned programming), so typofixing is the best and fasted thing they can do imo.

Btw consider letting whoever runs the course know that the arbitrary tag with 0 context is a very weird choice. Especially for a title which is sometimes automated into release notes. PR body would be a better place IMO for it but I know it's most likely not up to you.

Already did, I also think it's a bad choice but the lecturer didn't want to change it (but you can still say it @MrMars98, maybe he'll change his mind if more students mention it). He uses some script to crawl all PRs the students send to him to check if the title contains the hashtag (at least it was like that when I visited it).

@MrMars98
Copy link
Author

MrMars98 commented Jul 3, 2025

Already did, I also think it's a bad choice but the lecturer didn't want to change it (but you can still say it @MrMars98, maybe he'll change his mind if more students mention it). He uses some script to crawl all PRs the students send to him to check if the title contains the hashtag (at least it was like that when I visited it).

Yeah, the whole course pretty much told him that it's stupid and he said he will consider changing it for the next time he does it (he probably won't). The hashtag is unfortunately required in the title.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants