Skip to content

Support Basic Authentication for archive downloads #35087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Basic Authentication for archive downloads #35087

wants to merge 1 commit into from
+2 −2

Conversation

pvgoran
Copy link

@pvgoran pvgoran commented Jul 15, 2025

Resolves #35083

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 15, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 15, 2025
@pvgoran
Copy link
Author

pvgoran commented Jul 15, 2025

It just occurred to be that the PR/commit title should say "repository archive" rather than just "archive". Not changing it now since https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#maintaining-open-prs possibly implies that I shouldn't. (Unless someone says it's OK to do.)

@lunny
Copy link
Member

lunny commented Jul 15, 2025

It's better to have a test for that.

@pvgoran
Copy link
Author

pvgoran commented Jul 15, 2025

It's better to have a test for that.

Where could a test be added, what would it test, and how would I run such a test? (I don't know a thing about testing facilities of Gitea - or of Go in general, for that matter.)

When I look at #33371 for inspiration, I only find something that looks like a test for the isFeedRequest() function. Here, do I need to test just the isArchivePath() function in a similar way, too?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 16, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jul 16, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Jul 16, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Basic authentication doesn't work for archive downloads
5 participants
@pvgoran @lunny @wxiaoguang @hiifong @GiteaBot