-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Use configurable remote name in snippets #35172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use configurable remote name in snippets #35172
Conversation
Maybe it should be a per repository setting but not a global one. |
I think we can get started with a global one, and then if needed, make it more precise. |
Even if you intend to add a global configuration, please store it in the database rather than in app.ini. |
Done! |
Does the title “Repository Snippets” in the configuration accurately reflect its purpose? It might be more appropriate under the Pull Request Settings section. |
This setting affects two pages at once:
Therefore, I would choose a more general name. I am open to any suggestions. |
services/context/repo.go
Outdated
@@ -542,6 +542,7 @@ func RepoAssignment(ctx *Context) { | |||
ctx.Data["CanWriteIssues"] = ctx.Repo.CanWrite(unit_model.TypeIssues) | |||
ctx.Data["CanWritePulls"] = ctx.Repo.CanWrite(unit_model.TypePullRequests) | |||
ctx.Data["CanWriteActions"] = ctx.Repo.CanWrite(unit_model.TypeActions) | |||
ctx.Data["SnippetRemoteName"] = setting.Config().Repository.SnippetRemoteName.Value(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and above: we can remove this SnippetRemoteName
from template data, and get its value directly from the templates that need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is used in several places in the template, I think it makes sense to extract it into a variable, which is what I did.
…lya-nurullin/gitea into feat/custom-remote-in-snippets
But it is also for "templates/repo/issue/view_content/pull_merge_instruction.tmpl", it is a guide for end users to checkout the repo into their local clone. So I think |
Closes #19403, and makes it possible to use any remote name in code snippets for an empty repository and pull request.
This change is very helpful to me, because I always use different name for my gitea remote.
Uses setting config module to store the value. Default is
origin
for backward compatibility.Screenshots
Empty repo
Pull Request
Settings page