Skip to content

Remove deprecated auth sources #35272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

techknowlogick
Copy link
Member

Entra ID users should use the OIDC oauth2 provider.

They will still be shown if the instance has a previous Azure AD source configured.

Entra ID users should use the OIDC oauth2 provider
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 13, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 13, 2025
@techknowlogick techknowlogick requested a review from lunny August 15, 2025 18:36
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2025
@techknowlogick techknowlogick requested a review from lunny August 18, 2025 03:23
providers := make([]Provider, 0, len(gothProviders))
hasExistingAzure := hasExistingAzureADAuthSources(ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean

existAuthSources := getExistingAzureADAuthSources(ctx)
for _, provider := range gothProviders {
		if isAzureProvider(provider.Name()) && !slices.Contains(existAuthSources, provider.Name()) {
			continue
		}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants