Skip to content
This repository has been archived by the owner on Jun 21, 2019. It is now read-only.

move to drone 1.0.0 #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

move to drone 1.0.0 #43

wants to merge 6 commits into from

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jan 17, 2019

As title

Edit: Next steps include requesting a Drone Enterprise key from: https://my.drone.io/order/personal (ask Brad first if it's ok to use for Gitea, because it's not entirely personal but it's also not for business), and also setting up runners on ARM servers.

@techknowlogick techknowlogick requested a review from lunny January 17, 2019 04:17
@appleboy
Copy link
Member

appleboy commented Jan 17, 2019

I think we can't move to latest version of drone before drone release source code. If so, we can try the free cloud service of drone.

@lunny
Copy link
Member

lunny commented Jan 17, 2019

@techknowlogick I agree with @appleboy we should use stable version of drone.

@tboerger
Copy link
Member

There is also no automated upgrade path, currently you will loose the secrets and the entire build logs, even with the migration tool.

@techknowlogick techknowlogick changed the title move to drone 1.0.0-rc4 move to drone 1.0.0 Feb 14, 2019
@appleboy
Copy link
Member

drone release 1.0?

@techknowlogick
Copy link
Member Author

@appleboy per suggestions I decided against using RC. So I will wait until 1.0.0 is released

drone_orgs: go-gitea
drone_admins: lafriks,lunny,techknowlogick
drone_server_host: drone.gitea.io
drone_user_filter: lafriks,lunny,techknowlogick,go-gitea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be just:

Suggested change
drone_user_filter: lafriks,lunny,techknowlogick,go-gitea
drone_user_filter: go-gitea

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There user filter won't be used at all anymore, admins are stored in the database now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand from docs only users/org users listed here will be able to authorize in this instance

drone_orgs: go-gitea
drone_admins: lafriks,lunny,techknowlogick
drone_server_host: drone.gitea.io
drone_user_filter: lafriks,lunny,techknowlogick,go-gitea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you should add:

drone_user_create: username:lafriks,admin:true

or lunny or yourself :)

@techknowlogick
Copy link
Member Author

Migration tool just updated with ability to migrate logs. Will run migration locally and comment on this PR if it is successful.

@techknowlogick
Copy link
Member Author

I ran the migration using the migration utility, and the DB went from 6.3GB->5.9GB. It appears as though everything has been migrated (from a few queries comparing the two DBs).

I think this is ready for review now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants