Skip to content
This repository has been archived by the owner on May 24, 2019. It is now read-only.

initial imlementation of list repos (#3) #13

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

root360-AndreasUlm
Copy link
Contributor

  • implemented runRepos()
  • reimplemented issues.initCommand() as repos.initCommandLoginOnly() as repos command does not always need a valid repository argument.

Output:

$ go build && ./tea repos --login try
Name    Type/Mode       SSH-URL Owner
test-orga/test source  [email protected]:test-orga/test.git    test-user

Signed-off-by: Andreas Ulm [email protected]

Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR 😄 Just a few nits.

cmd/repos.go Outdated Show resolved Hide resolved
cmd/repos.go Outdated Show resolved Hide resolved
Signed-off-by: Andreas Ulm <[email protected]>
@lunny
Copy link
Member

lunny commented Apr 16, 2019

I think noheader flag seems unnecessary. We always needs a header. But for format print on console, \t will not always available.

@root360-AndreasUlm
Copy link
Contributor Author

root360-AndreasUlm commented Apr 16, 2019

I think noheader flag seems unnecessary. We always needs a header.

@lunny I just added the option to allow further output usage without requiring something like | tail -n -1 | to exclude the header.

But for format print on console, \t will not always available.

I just copied the output format from pulls.runPulls().

@root360-AndreasUlm
Copy link
Contributor Author

@lunny removed header flag and changed delimiter to pipe.

When I'm done with the unified output ( https://github.com/root360-AndreasUlm/tea/tree/unified_output_function ) the output of this function will be changed again.

@techknowlogick techknowlogick dismissed their stale review April 25, 2019 16:25

dimissing my review as requested changes have been made

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants