feat: impl clause.Interface for using #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better to update the gen to support this. |
|
我觉得这边在gen改并不好改，dbresolver的using是私有的，gen并没有办法判断这个类型，大佬再看看？ |
|
gen 的 CheckClause 安全检查不太合理，后续应该会改改这个 |
|
好的，谢谢大佬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
impl clause.Interface for using
User Case Description
see go-gorm/gen#982
#117
如果我想要让
Clauses(dbresolver.Use("db_1")可以正常被使用，需要让dbresolver.using实现clause.Interface接口If I want 'Clauses(dbresolver.Use("db_1")' to be used normally, I need 'dbresolver.using' to implement the clause.Interface 'interface