Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Fix URL for authentik installation instead of mobilizon installation #12729

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

cassie-nahar
Copy link
Contributor

Mobilizon needs to know where to look to find authentik, not where to look to find itself.

Details

Current documentation for Mobilizon integration says to point Mobilizon to itself. It should say to point Mobilizon to Authentik.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Mobilizon needs to know where to look to find authentik, not where to look to find itself.

Signed-off-by: Cassie Nahar <[email protected]>
@cassie-nahar cassie-nahar requested a review from a team as a code owner January 17, 2025 20:39
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 061059b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/678abff679105a0008a5e1c2
😎 Deploy Preview https://deploy-preview-12729--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 061059b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/678abff633a0b80008601f73
😎 Deploy Preview https://deploy-preview-12729--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for catching this mistake

@BeryJu BeryJu changed the title Fix URL for authentik installation instead of mobilizon installation website/integrations: Fix URL for authentik installation instead of mobilizon installation Jan 17, 2025
@BeryJu BeryJu enabled auto-merge (squash) January 17, 2025 21:48
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (7c71f9f) to head (061059b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12729   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         769      769           
  Lines       38898    38898           
=======================================
+ Hits        36082    36083    +1     
+ Misses       2816     2815    -1     
Flag Coverage Δ
e2e 48.58% <ø> (ø)
integration 24.62% <ø> (ø)
unit 90.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit e988799 into goauthentik:main Jan 17, 2025
64 of 67 checks passed
kensternberg-authentik added a commit that referenced this pull request Jan 21, 2025
* main: (65 commits)
  stages/redirect: fix query parameter when redirecting to flow (#12750)
  website/integrations: cloudflare-access: refactor (#12663)
  sources/kerberos: handle principal expire time (#12748)
  lifecycle: build binary dependencies which link against SSL directly (#12724)
  website/docs: style guide: document styling preferences for URLs (#12715)
  website/integrations: nextcloud: fix broken link (#12744)
  core: bump selenium from 4.27.1 to 4.28.0 (#12745)
  lifecycle: move AWS CFN generation to lifecycle and fix CI (#12743)
  core: search users' attributes (#12740)
  web/components: ak-number-input: add support for min (#12703)
  website/integrations: nextcloud: fix url for "disable username changes" (#12725)
  core: bump pytest-github-actions-annotate-failures from 0.2.0 to 0.3.0 (#12735)
  website: bump katex from 0.16.11 to 0.16.21 in /website (#12731)
  web: bump katex from 0.16.11 to 0.16.21 in /web (#12730)
  website/integrations: Fix URL for authentik installation instead of mobilizon installation (#12729)
  core: bump debugpy from 1.8.11 to 1.8.12 (#12718)
  core: bump ruff from 0.9.1 to 0.9.2 (#12717)
  core: bump webauthn from 2.4.0 to 2.5.0 (#12719)
  core: bump structlog from 24.4.0 to 25.1.0 (#12720)
  website/integrations: all: install -> installation (#12676)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants