BEDS-1011/Gray-out archived dashboard rows in notifications management modal #1338
+52
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifications management modal - (BcTablePopoutEdit): improve accessibility by wrapping clickable icon with a button - replace inexisting `custom property` used for disabled link color
Deploying beaconchain with
|
| Latest commit: |
02386f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://77ba3776.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-1101-gray-out-archived.beaconchain.pages.dev |
marcel-bitfly
requested changes
Feb 24, 2025
| @@ -4,12 +4,13 @@ import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome' | |||
|
|
|||
| const emit = defineEmits<{ (e: 'onEdit'): void }>() | |||
|
|
|||
| interface Props { | |||
| defineProps<{ | |||
| disabled?: boolean, | |||
There was a problem hiding this comment.
our naming convention is boolean props are starting with is- or has-
Understandably the question arises what is with DOM attributes:
- they could be applied via
fallthrough - so if we specify a
public api via our own propswe should stick to ourconventions
Suggested change
| disabled?: boolean, | |
| isDisabled?: boolean, |
| @@ -273,7 +291,9 @@ const handleDelete = (payload: Parameters<typeof deleteDashboardNotifications>[0 | |||
| :header="$t('notifications.col.group')" | |||
| > | |||
| <template #body="slotProps"> | |||
| {{ slotProps.data.group_name }} | |||
| <span :class="slotProps.data.is_archived ? 'disabled-text' : ''"> | |||
There was a problem hiding this comment.
more concise:
Suggested change
| <span :class="slotProps.data.is_archived ? 'disabled-text' : ''"> | |
| <span :class="{'disabled-text': slotProps.data.is_archived}> |
| label?: string, | ||
| noIcon?: boolean, |
Comment on lines
+225
to
+227
| const isDeleteButtonDisabled = (dashboard: WrappedRow) => { | ||
| return !dashboard.subscriptions?.length || dashboard.is_archived | ||
| } |
There was a problem hiding this comment.
easier to reason about:
Suggested change
| const isDeleteButtonDisabled = (dashboard: WrappedRow) => { | |
| return !dashboard.subscriptions?.length || dashboard.is_archived | |
| } | |
| const isDeleteButtonDisabled = (dashboard: WrappedRow) => { | |
| const hasSubscriptions = dashboard.subscriptions?.length | |
| return !hasSubscriptions || dashboard.is_archived | |
| } |
| <span> | ||
| <BcTooltip | ||
| v-if="slotProps.data.is_archived" | ||
| tooltip-width="320px" |
There was a problem hiding this comment.
this might suffice: (😪 applying it by default would be best)
Suggested change
| tooltip-width="320px" | |
| fit-content |
| <FontAwesomeIcon | ||
| v-if="!noIcon" | ||
| <BcButtonIcon | ||
| :screenreader-text="$t('common.edit')" |
There was a problem hiding this comment.
well ideally we would give more context what the button is doing, but I guess this is fine for now
| tooltip-width="320px" | ||
| tooltip-text-align="left" | ||
| class="disabled-text" | ||
| :text="'This dashboard has been archived.'" |
There was a problem hiding this comment.
plz use a translation here
| @@ -332,22 +356,25 @@ const handleDelete = (payload: Parameters<typeof deleteDashboardNotifications>[0 | |||
| <template #expansion="slotProps"> | |||
| <div class="expansion"> | |||
| <div class="info"> | |||
| <div class="label"> | |||
| <div :class="['label', slotProps.data.is_archived ? 'text-disabled' : '']"> | |||
There was a problem hiding this comment.
more concise and more explicit which parts are conditional which are not
Suggested change
| <div :class="['label', slotProps.data.is_archived ? 'text-disabled' : '']"> | |
| <div | |
| class="label" | |
| :class="{'text-disabled' : slotProps.data.is_archived }"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.