Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(executionlayer/reorg): separate reorg process + tests #1339

Open
wants to merge 2 commits into
base: NOBIDS/refactor-store
Choose a base branch
from
Open

refactor(executionlayer/reorg): separate reorg process + tests #1339

wants to merge 2 commits into from
+1,354 −516

Conversation

Tangui-Bitfly
Copy link
Contributor

@Tangui-Bitfly Tangui-Bitfly commented Feb 19, 2025 •
edited
Loading

  • extract reorg logic from main and db/bigtable
  • put cache interface into db2/database
  • add some options filter for db2/database/Database
  • db2/database/databasetest export a test utility function to run a Redis in docker using testcontainer
    • skip test if docker is not running
  • migrate indexing func from main and db/bigtable to executionlayer/indexer
    • I'm not happy with the current implementation, I will work on an overall refactor of the main and indexer interaction later on

@Tangui-Bitfly Tangui-Bitfly marked this pull request as ready for review February 20, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invis-bitfly invis-bitfly Awaiting requested review from invis-bitfly

@mccreedy-bitfly mccreedy-bitfly Awaiting requested review from mccreedy-bitfly

@Monika-Bitfly Monika-Bitfly Awaiting requested review from Monika-Bitfly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tangui-Bitfly