refactor: revise and add tests for exporter/modules/genesis_deposit.go
#1354
+489
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tangui-Bitfly
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Your tests are taking too long to execute
ok github.com/gobitfly/beaconchain/pkg/exporter/modules 71.193s coverage: 0.7% of statements
It should not be over, let say, 5s (and it's very generous)
| client: client, | ||
| db: db, | ||
| offset: time.Minute, | ||
| ctx: context.Background(), |
There was a problem hiding this comment.
ctx should be a param of Export
The usage would be
// in main.go
ctx, cancel := context.WithCancel(context.Background())
go modules.StartAll(ctx, ...)
// wait for something
cancel()
// in backend/pkg/exporter/modules/base.go
func StartAll(ctx context.Context, ...) {
...
go newGenesisDepositsExporter(context.ConsClient, dbs).Export(ctx)This a good change but I think it's too soon.
There was a problem hiding this comment.
In the end this is probably not needed, we have an exit condition on this go routine with
if genesisDepositCount > 0 {
return
}
backend/pkg/commons/db/db.go
Outdated
| type ConsensusDBI interface { | ||
| GetLatestEpoch() (uint64, error) | ||
| GetDepositsCountForBlockSlot() (uint64, error) | ||
| SaveBlockDeposits(validatorIndex uint64, pubkey []byte, withdrawalCredentials []byte, balance uint64) error |
There was a problem hiding this comment.
this should accept types.StandardValidator
There was a problem hiding this comment.
using types.StandardValidator triggers a lint error due to a dependency rule tho
There was a problem hiding this comment.
Even with this syntax ?
import (
constypes "github.com/gobitfly/beaconchain/pkg/consapi/types"
)
func (d *ConsensusDB) SaveBlockDeposits(validator constypes.StandardValidator) error {
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.