Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(BEDS-1215) Pectra withdrawals #1370

Open
wants to merge 2 commits into
base: BEDS-96/pectra-api-review
Choose a base branch
from
Open

(BEDS-1215) Pectra withdrawals #1370

wants to merge 2 commits into from
+315 −12

Conversation

remoterami
Copy link
Contributor

Based on #1365

@remoterami
fix: added pectra configs
e2fe2c7 
(cherry picked from commit a17f8f8)
(cherry picked from commit 2450ba3)
@remoterami
feat: pectra withdrawals
f0585af
sasha-bitfly
sasha-bitfly reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@sasha-bitfly sasha-bitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, write a unit test for GetMaxEffectiveBalanceByWithdrawalCredentials

sasha-bitfly
sasha-bitfly reviewed Feb 28, 2025
View reviewed changes
backend/pkg/commons/utils/utils.go
@@ -387,6 +387,18 @@ func GetWithdrawalCredentialsOfAddress(addr common.Address) []byte {

return result
}
func GetMaxEffectiveBalanceByWithdrawalCredentials(withCred []byte) uint64 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, write unit test for GetMaxEffectiveBalanceByWithdrawalCredentials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-bitfly sasha-bitfly sasha-bitfly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remoterami @sasha-bitfly