Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gc_ruboconfig requirement from ~> 4.4.2 to ~> 5.0.2 #77

Merged
merged 9 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
tests:
strategy:
matrix:
ruby-version: [2.7, 3.0, 3.1, 3.2]
ruby-version: [3.0, 3.1, 3.2, 3.3, 3.4]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -33,14 +33,14 @@ jobs:
integration:
strategy:
matrix:
ruby-version: [2.7, 3.0, 3.1, 3.2]
ruby-version: [3.0, 3.1, 3.2, 3.3, 3.4]
runs-on: ubuntu-latest
env:
STORAGE_EMULATOR_HOST: "http://localhost:9023/"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Start minio and GCS simulator
run: docker-compose up -d
run: docker compose up -d
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand Down
4 changes: 1 addition & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ inherit_gem:
AllCops:
TargetRubyVersion: 2.6
DisplayCopNames: true
NewCops: enable

Layout/LineLength:
Max: 100
Expand All @@ -30,9 +31,6 @@ RSpec/LetSetup:
RSpec/MultipleExpectations:
Max: 10

RSpec/Rails/AvoidSetupHook:
Enabled: true

RSpec/ExampleWording:
Enabled: false

Expand Down
7 changes: 7 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,10 @@
source "https://rubygems.org"

gemspec

gem "gc_ruboconfig", "~> 5.0.2"
gem "nokogiri", "~> 1.17.2"
gem "pry-byebug", "~> 3.10"
gem "rspec", "~> 3.13"
gem "rspec-github", "~> 2.4.0"
gem "rubocop", ">= 1.63"
7 changes: 1 addition & 6 deletions bucket_store.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,10 @@ Gem::Specification.new do |s|

s.files = Dir["lib/**/*", "README.md"]

s.required_ruby_version = ">= 2.7"
s.required_ruby_version = ">= 3.0"

s.add_dependency "aws-sdk-s3", ">= 1.147"
s.add_dependency "google-cloud-storage", ">= 1.50"

s.add_development_dependency "gc_ruboconfig", "~> 4.4.2"
s.add_development_dependency "pry-byebug", "~> 3.10"
s.add_development_dependency "rspec", "~> 3.13"
s.add_development_dependency "rspec-github", "~> 2.4.0"
s.add_development_dependency "rubocop", ">= 1.63"
s.metadata["rubygems_mfa_required"] = "true"
end
2 changes: 1 addition & 1 deletion docs/COMPATIBILITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ is supported.
To that end, [our build matrix](../.circleci/config.yml) includes all these versions.

Any time BucketStore doesn't work on a supported version of Ruby, it's a bug, and can be
reported [here](https://github.com/gocardless/file-storage/issues).
reported [here](https://github.com/gocardless/bucket-store/issues).

# Deprecation

Expand Down
Loading