Implement CSV schema detection + fix loading from GCS emulator #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit specific to my use case – namely loading a CSV from https://github.com/fsouza/fake-gcs-server and implementing schema detection for at least a few different basic types, including UK dates 😅
I couldn't find existing schema detection code which was a bit surprising, but maybe I just overlooked it?
But I think this could be very useful for people in a similar situation, so even if it doesn't get merged, at least people can see a solution?
Also happy to spend a bit of time on it if there are some concrete changes needed before it's mergeable! Caveat is that I'm not a Go developer, so apologies if it's not idiomatic...