Wasm unit tests on CI #1275
Wasm unit tests on CI #1275
Conversation
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1275 |
PgBiel
force-pushed
the
wasm-unit-tests
branch
3 times, most recently
from
8f3e5bd to
556bb1c
Compare
Bromeon
force-pushed
the
master
branch
2 times, most recently
from
779c043 to
ddc5b76
Compare
| #[cfg_attr( | ||
| all(target_family = "wasm", not(target_feature = "atomics")), | ||
| ignore = "Threading not available" | ||
| )] |
There was a problem hiding this comment.
Might be worth a module to not annotate each individual test? 🙂
| ./emsdk/emsdk install $EMSCRIPTEN_VERSION | ||
| ./emsdk/emsdk activate $EMSCRIPTEN_VERSION | ||
| source ./emsdk/emsdk_env.sh | ||
| echo PATH=$PATH >> $GITHUB_ENV |
There was a problem hiding this comment.
| echo PATH=$PATH >> $GITHUB_ENV | |
| echo "PATH=$PATH" >> $GITHUB_ENV |
I don't expect spaces, but these are a real pain to debug 😬
But apart from that, this just defines it with itself?
Should we not use GITHUB_PATH?
There was a problem hiding this comment.
Good point, I didn't know about that variable. We should probably be using it.
| # More memory (256 MiB) is needed for the parallel godot-cell tests which | ||
| # spawn 70 threads each. |
There was a problem hiding this comment.
Good observation. Do you think this still makes sense, pushing the limits also on web?
There was a problem hiding this comment.
I think it's fine for what it's worth. We could consider reducing the tests a bit, but I'd rather get existing tests to work first.
since it's only used for tests
no feature needed
this needs fixing in the book
this might call for another composite... second attempt at pinning emscripten
Bromeon
force-pushed
the
wasm-unit-tests
branch
from
556bb1c to
27dab3d
Compare
| ./emsdk/emsdk install $EMSCRIPTEN_VERSION | ||
| ./emsdk/emsdk activate $EMSCRIPTEN_VERSION | ||
| source ./emsdk/emsdk_env.sh | ||
| echo PATH=$PATH >> $GITHUB_ENV |
There was a problem hiding this comment.
Good point, I didn't know about that variable. We should probably be using it.
| #[cfg_attr( | ||
| all(target_family = "wasm", not(target_feature = "atomics")), | ||
| ignore = "Threading not available" | ||
| )] |
| # More memory (256 MiB) is needed for the parallel godot-cell tests which | ||
| # spawn 70 threads each. |
There was a problem hiding this comment.
I think it's fine for what it's worth. We could consider reducing the tests a bit, but I'd rather get existing tests to work first.
Runs wasm unit tests on CI. Browsers / exports not tested here yet.
Full details here https://typst.app/project/r314DoDea5XiYYr5bq5IFP
(I will summarize them here later)
P.S. I'll be organizing commits later, sorry for the mess :)
TODO:
test_global_would_blocktest inglobal.rswhen testing Wasm nothreads