Skip to content

Fix binding generation for TypedArray/TypedDictionary with refcounted elements. #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix binding generation for TypedArray/TypedDictionary with refcounted elements. #1794

wants to merge 1 commit into from
+15 −2

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 18, 2025

See godotengine/godot#107660

It was generating invalid TypedDictionary<String, Font> type, now it's TypedDictionary<String, Ref<Font>>. Existing bindings should not change.

@bruvzg bruvzg requested a review from a team as a code owner June 18, 2025 10:21
@bruvzg bruvzg added bug This has been identified as a bug enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Jun 18, 2025
dsnopek
dsnopek approved these changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I haven't tested, but the code looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug cherrypick:4.4 enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @dsnopek