Skip to content

Files generated by SCons should depend on the build_profile (if given) #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jun 18, 2025

On godot_openxr_vendors, we've been having this problem with the SCons cache on CI, where if a PR adds something to the build_profile.json it'll still use outdated generated files from the cache.

This change attempts to make it so that it'll rebuild the generated files if the build_profile.json changes

I'm still not entirely sure this fixes the issue, because it's hard to test in the context of CI, but I'll see what I can do!

And I'd also appreciate feedback from folks who are more experienced with build system stuff

UPDATE: I've managed to do some testing (see this comment), and it seems to be working

@dsnopek dsnopek added this to the 4.x milestone Jun 18, 2025
@dsnopek dsnopek requested a review from a team as a code owner June 18, 2025 19:49
@dsnopek dsnopek added bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup labels Jun 18, 2025
@dsnopek
Copy link
Collaborator Author

dsnopek commented Jun 18, 2025

This does seem to fix the issue with godot_openxr_vendor's CI.

We were having the issue on master, and I was experiencing it on a PR as well. So, I first tried using these changes on the PR: it fixed it. So, I merged just those changes into master as well: fixed it there too!

We'll keep testing it there for a bit and see if the issue manages to recur :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant