Files generated by SCons should depend on the build_profile
(if given)
#1795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On godot_openxr_vendors, we've been having this problem with the SCons cache on CI, where if a PR adds something to the
build_profile.json
it'll still use outdated generated files from the cache.This change attempts to make it so that it'll rebuild the generated files if the
build_profile.json
changesI'm still not entirely sure this fixes the issue, because it's hard to test in the context of CI, but I'll see what I can do!And I'd also appreciate feedback from folks who are more experienced with build system stuff
UPDATE: I've managed to do some testing (see this comment), and it seems to be working