Clarify COLOR and TEXTURE in CanvasItem shaders #10107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhilbrunner
reviewed
Oct 18, 2024
mhilbrunner
added
enhancement
area:manual
tetrapod00
force-pushed
the
canvasitem-shader-color-texture
branch
from
3870c0b to
be84df8
Compare
mhilbrunner
approved these changes
Oct 19, 2024
|
Thank you! |
|
This one would be nice to cherrypick, but as an (extensive) clarification, it's non-essential. Was the problem the table being reformatted? |
|
Cherrypicked to 4.3 in #10356. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies how to read either the main texture, the vertex
COLOR, or both in CanvasItem shaders.With this PR, all three options available (only
COLOR, onlyTEXTURE, or both) are cleanly listed with snippets. Also, the role ofCOLORinfragment()andvertex()is also clearly listed. This is slightly redundant with the tables themselves but worth the increase in clarity.I've seen a fair bit of confusion about this in help chats, also people looking for the old
MODULATEvalue from 3.x. This should help with both issues.While I was here I corrected one use of bold instead of
CODEstyling in one of the tables.