Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about shader uniform size limit to Shading Language #10153

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add note about shader uniform size limit to Shading Language #10153

merged 1 commit into from
Oct 28, 2024

Conversation

tetrapod00
Copy link
Contributor

This PR documents the limit on the total size of shader uniforms . I adapted some of the information from godotengine/godot#55674 into a note on the Shading Language page. I kept the note as concise as I could.

clayjohn
clayjohn reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a helpful addition, I added a few suggestions.

tutorials/shaders/shader_reference/shading_language.rst Outdated Show resolved Hide resolved
tutorials/shaders/shader_reference/shading_language.rst Outdated Show resolved Hide resolved
@tetrapod00 tetrapod00 force-pushed the shader-uniform-limit branch from b9b91cc to a2dc843 Compare October 28, 2024 00:35
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders labels Oct 28, 2024
@tetrapod00 tetrapod00 force-pushed the shader-uniform-limit branch from a2dc843 to 58867df Compare October 28, 2024 16:14
@mhilbrunner mhilbrunner merged commit d904c1d into godotengine:master Oct 28, 2024
1 check passed
@tetrapod00 tetrapod00 deleted the shader-uniform-limit branch October 28, 2024 20:03
@mhilbrunner
Copy link
Member

Thanks!

@tetrapod00
Copy link
Contributor Author

Still a cherrypick to 4.3 IMO. It's an enhancement but I don't see any potential conflicts it could cause.

@tetrapod00 tetrapod00 mentioned this pull request Nov 30, 2024
Merged
@tetrapod00
Copy link
Contributor Author

Cherrypicked to 4.3 in #10356.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@clayjohn clayjohn clayjohn approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:shaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tetrapod00 @mhilbrunner @clayjohn @AThousandShips