Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file_access.h location #10328

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

esainane
Copy link
Contributor

os/file_access.h moved to io/file_access.h in godotengine/godot@9e328bb5b.

Interestingly, the label in the bulleted list was updated, but the link itself was not.

`os/file_access.h` moved to `io/file_access.h` in 9e328bb5b:
godotengine/godot@9e328bb5b
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense and the new link works. This should have a second look from someone more familiar with the codebase.

@tetrapod00 tetrapod00 added bug area:contributing Issues and PRs related to the Contributing/Development section of the documentation cherrypick:4.3 labels Nov 29, 2024
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file was moved in this PR: godotengine/godot#49511

@skyace65 skyace65 merged commit 01f118e into godotengine:master Nov 29, 2024
1 check passed
@skyace65
Copy link
Contributor

Thanks!

@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants